Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements in cluster members subsystem #22677

Merged
merged 6 commits into from
Aug 1, 2024

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Aug 1, 2024

Added some improvements making it easier to track the cluster membership issues. Additionally, added a test decommissioning each cluster node and then adding it back to the cluster, either with an overridden node id or with the new node id assigned by the controller. This test is similar to the chaos tests using recycle_all failure.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
Changed logging around applying controller commands to the members state
to be more consistent.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
Signed-off-by: Michał Maślanka <michal@redpanda.com>
Added log entry informing user about an issue that occurred when a
command was applied to the `members_table`

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv changed the title Recycle all test Logging improvements in cluster members subsystem Aug 1, 2024
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Aug 1, 2024

new failures in https://buildkite.com/redpanda/redpanda/builds/52351#01910d14-82f4-4971-8c97-0ab32b8e601b:

"rptest.tests.nodes_decommissioning_test.NodesDecommissioningTest.test_recycle_all_nodes.auto_assign_node_id=False"

new failures in https://buildkite.com/redpanda/redpanda/builds/52351#01910d14-82f6-44dd-a4a5-4fe49b3492d6:

"rptest.tests.nodes_decommissioning_test.NodesDecommissioningTest.test_recycle_all_nodes.auto_assign_node_id=True"

Added a test decommissioning each cluster node and then adding it back
to the cluster, either with an overridden node id or with the new node
id assigned by the controller. This test is similar to the chaos tests
using `recycle_all` failure.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv merged commit 64d7f01 into redpanda-data:dev Aug 1, 2024
20 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants