[v24.2.x] admin: remove throw on unknown self test type in admin_server
#22698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For logging purposes, when an unrecognized test type is requested through the `self_test_start_handler`, it will be abstracted by the `unknown_check` struct. (cherry picked from commit aa93f3f)
(cherry picked from commit 93b1901)
This commit removes the `throw` statement in `admin_server::self_test_start_handler()` and replaces it instead with a `push_back()` to `self_test_request::unknown_checks`. Eventually, these unknown checks will have a result displayed when `rpk cluster self-test status` is invoked. For the self-test, any unrecognized tests will be appended to `start_test_request::unknown_checks`, so a future result from `rpk cluster self-test status` will return a message indicating an unknown test was skipped. (cherry picked from commit 4e99539)
For testing of the previous change in which unknown test types are added to `start_test_request::unknown_checks`, instead of resulting in a `throw`. (cherry picked from commit 3bac4dc)
`test_type` was not being set in early exit cases for `cloudcheck`. This would result in longer than expected output (with `IOPS`, `THROUGHPUT`, `LATENCY` in `rpk cluster self-test status`). (cherry picked from commit 147d5e9)
WillemKauf
approved these changes
Aug 2, 2024
WillemKauf
reviewed
Aug 2, 2024
| @@ -321,14 +341,15 @@ struct empty_request | |||
| struct start_test_request | |||
| : serde::envelope< | |||
| start_test_request, | |||
| serde::version<0>, | |||
| serde::version<1>, | |||
There was a problem hiding this comment.
This serde::version<> needs bumping to serde::version<2>, here and in dev, since serde::version<0> is the version of start_test_request with just diskcheck_opts, netcheck_opts, serde::version<1> is the version with unknown_checks added, and serde::version<2> needs to reflect the most recently added cloudcheck_opts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21370