[v24.1.x] CORE-5686 Decouple different raft group shutdown sequences #22768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a log entry when partition is removed to make debugging partition shutdown issues easier. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 5f457ef)
ztlpn
approved these changes
Aug 7, 2024
Individual raft groups shutdown operations are not correlated and do not need coordination with mutex. The `group_manager::_groups` vector is always updated in synchronous parts of code therefore it do not require the mutex either. Removed the mutex to make shutting down different Raft groups independent from each other. Fixes CORE-5686 Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit e0236f6)
mmaslankaprv
force-pushed
the
backport-21517-v24.1.x-88
branch
from
ed83ab8 to
adf2c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #21517