Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k/group: do not replicate empty offsets commit batch #22797

Merged
merged 1 commit into from
Aug 9, 2024
Merged

k/group: do not replicate empty offsets commit batch #22797

merged 1 commit into from
Aug 9, 2024
+18 −15

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Aug 8, 2024 •
edited
Loading

If an ongoing transactions has no offsets to update we must skip creating offset store batch as it leads to replication of an empty batch and assertion.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

bharathv
bharathv previously approved these changes Aug 8, 2024
View reviewed changes
src/v/kafka/server/group.cc Show resolved Hide resolved
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52668#019132ab-19b9-4fd1-a8fa-4f4576a16590

@mmaslankaprv mmaslankaprv force-pushed the fix-replicating-empty-batch branch from 0a7423a to 430fb1e Compare August 9, 2024 11:16
@mmaslankaprv mmaslankaprv requested a review from bharathv August 9, 2024 11:16
@mmaslankaprv
k/group: do not replicate empty offsets commit batch
e696614 
If an ongoing transactions has no offsets to update we must skip
creating offset store batch as it leads to replication of an empty batch
and assertion.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv force-pushed the fix-replicating-empty-batch branch from 430fb1e to e696614 Compare August 9, 2024 11:22
@mmaslankaprv mmaslankaprv merged commit 5c5b4ef into redpanda-data:dev Aug 9, 2024
19 checks passed
@mmaslankaprv mmaslankaprv deleted the fix-replicating-empty-batch branch August 9, 2024 14:41
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Aug 9, 2024
Merged
@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-22797-v23.3.x-231 remotes/upstream/v23.3.x
git cherry-pick -x e6966144dd401e15e3cdd68837956e15c0146828

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Aug 9, 2024
Open
@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-22797-v24.1.x-597 remotes/upstream/v24.1.x
git cherry-pick -x e6966144dd401e15e3cdd68837956e15c0146828

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Aug 9, 2024
Closed
@mmaslankaprv mmaslankaprv mentioned this pull request Aug 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathv bharathv bharathv approved these changes

@bashtanov bashtanov Awaiting requested review from bashtanov

@ztlpn ztlpn Awaiting requested review from ztlpn

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmaslankaprv @vbotbuildovich @bharathv