kafka/group: don't replicate empty batch on offset commit #22824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
force-pushed
the
group-offset-commit-empty
branch
from
4b66565 to
e751117
Compare
Redpanda generally does not permit empty batches to make their way to the log. This is problematic in case of an empty offset commit requests. Kafka returns immediately for empty requests[1], so this tweaks the return store_offsets() method to do the same. I considered putting this higher up in the Kafka layer, but there didn't seem to be a specialized handler for offsets commits where such an early return would be natural. [1] https://github.com/apache/kafka/blob/98cdf9717049e87ba34bb5161276577fcb8bd1c4/core/src/main/scala/kafka/server/KafkaApis.scala#L504-L505
andrwng
force-pushed
the
group-offset-commit-empty
branch
from
e751117 to
c0b2fc7
Compare
7 tasks
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52736#01913966-1d29-4c89-9e76-093595b135f7 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52736#0191397e-b067-4047-a61b-199f086505a4 |
bharathv
approved these changes
Aug 15, 2024
|
/backport v24.2.x |
|
/backport v24.1.x |
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redpanda generally does not permit empty batches to make their way to
the log. This is problematic in case of an empty offset commit requests.
Kafka returns immediately for empty requests[1], so this tweaks the
return store_offsets() method to do the same. I considered putting this
higher up in the Kafka layer, but there didn't seem to be a specialized
handler for offsets commits where such an early return would be natural.
[1] https://github.com/apache/kafka/blob/98cdf9717049e87ba34bb5161276577fcb8bd1c4/core/src/main/scala/kafka/server/KafkaApis.scala#L504-L505
Backports Required
Release Notes
Bug Fixes