Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application: print command line #22826

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

travisdowns
Copy link
Member

Somehow we've gotten away without printing the command line all this time. In some contexts it is printed out by some other component but we should print it out ourselves in Redpanda too.

Ref CORE-6746.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • The command line is now printed to the log at startup by the Redpanda process.

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/52732#01913948-b5c3-4ca7-b1c4-4e88b72b638b:

"rptest.tests.mirror_maker_test.TestMirrorMakerService.test_simple_end_to_end.source_type=kafka"

@travisdowns
Copy link
Member Author

/ci-repeat 1

@andijcr andijcr self-requested a review August 13, 2024 13:54
Somehow we've gotten away without printing the command line all this
time. In some contexts it is printed out by some other component but
we should print it out ourselves in Redpanda too.

Ref CORE-6746.
@travisdowns travisdowns force-pushed the td-print-command-line-args branch from 327a8cf to 119312b Compare August 13, 2024 15:23
@travisdowns
Copy link
Member Author

Applied suggestion to use std::span from @andijcr and force pushed.

@andijcr
Copy link
Contributor

andijcr commented Aug 13, 2024

apparently for the bazel build you need to add @fmt dep to application

diff --git a/src/v/redpanda/BUILD b/src/v/redpanda/BUILD
index d83c422e5c..43f13d4147 100644
--- a/src/v/redpanda/BUILD
+++ b/src/v/redpanda/BUILD
@@ -65,6 +65,7 @@ redpanda_cc_library(
         "@protobuf",
         "@protobuf//:protobuf_lite",
         "@seastar",
+        "@fmt",
     ],
 )
 

andijcr
andijcr previously approved these changes Aug 13, 2024
@travisdowns
Copy link
Member Author

apparently for the bazel build you need to add @fmt dep to application

Weird, because fmt:: was already being used by application.cc. I guess it's because the header file is included now?

@StephanDollberg
Copy link
Member

Weird, because fmt:: was already being used by application.cc. I guess it's because the header file is included now?

It's because of https://redpandadata.atlassian.net/wiki/spaces/CORE/pages/714670307/Bazel#Why-does-Bazel-complain-about-so-many-missing-dependencies%3F I think

Effectively, it always was a dependency, but now that we've added the
header we need to make it explicit, because Bazel.
Copy link
Contributor

@andijcr andijcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@travisdowns travisdowns merged commit a7c1a67 into redpanda-data:dev Aug 14, 2024
19 checks passed
@travisdowns travisdowns deleted the td-print-command-line-args branch August 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants