[v24.1.x] cluster: fix partition::may_read_from_cloud() for remote read replicas (manual backport)
#22887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
approved these changes
Aug 14, 2024
`may_read_from_cloud()` was modified with a sanity check with `remote_fetch_enabled()` to assert that `remote.read` is enabled for a topic before serving a timequery from cloud storage. However, it failed to consider the case of a remote read replica, which should always be able to read from cloud. Fix the condition by adding an `or` statement to `may_read_from_cloud()` which checks `is_read_replica_mode_enabled()`. (cherry picked from commit c1c287a)
WillemKauf
force-pushed
the
backport-pr-22868-v24.1.x-21
branch
from
3ecce90
to
b57a57f
Compare
|
Force push to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #22868.
Conflict with Boost -> GTest migration that occurred in
cloud_storage_e2e_test.ccpost versionv24.2.x.Fixes #22884.
Backports Required
Release Notes