[v24.1.x] CORE-6835 Fix first time compacted segment upload #22926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test creates compacted topic without TS. It produces the data and waits until the data is compacted. After that it enables TS for the topic. The archiver has to be able to upload the data. (cherry picked from commit 9bbe429)
The archival_policy::find_segment method has a bug which causes it to skip compacted segments unconditionally. The code checks if the segment that it found is compacted and if this is the case it advances the iterator to the next segment. This operation causes ntp_archiver to skip one segment. The uploaded segment doesn't line up with the previous one so the validation error is triggered. The commit also implements handling of gaps in a safe way. We're not supposed to have gaps in the log (even in compacted logs) so the implementation has linear complexity. It's not supposed to be used and is good enough to hadnle unexpected unique glitch. (cherry picked from commit de01321)
The test validates logic which was removed. Previousy, the uploader was skipping single compacted segment and now it will upload compacted segments. So the upload in the test should start from 0. (cherry picked from commit e2fd980)
piyushredpanda
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22812