[v24.1.x] [CORE-6807] kafka: change offset_out_of_range condition in replicated_partition::prefix_truncate()
#22944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would return an `error_code::offset_out_of_range` for a request where `kafka_truncation_offset <= start_offset`. This is different behavior from what most Kafka clients are expecting when issuing `DeleteRecords` requests. Change the condition to return early with a `error_code::none` result. Also, correct conditions for tests that would previously expect a truncate call with `offset <= start_offset` to fail with the new, expected behavior (which is success). (cherry picked from commit 06e7154)
Adds a wrapper function around `kafka-delete-records.sh` which can be used to issue `DeleteRecords` requests. (cherry picked from commit 4c85e83)
Uses `kafka-delete-records.sh` and `rpk trim-prefix` to assert that Redpanda and Kafka achieve parity for certain edge cases involving `DeleteRecords` requests. Uses both `redpanda` and `KafkaService` brokers as mixins. (cherry picked from commit a3f7130)
WillemKauf
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22905