[v24.2.x] Fix dissemination large shard count #22982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `update_leader_request` may only contain few of ntp leader updates. In this case using a `fragmented_vector` with large chunk size is a memory waste Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit e1be74a)
Previously each time the leadership update request was received by the `metadata_dissemination_handler` it created a copy for each of the shard on the shard handling the request. This is inefficient and may lead to OOM on the handler shard (especially for very large machines). Instead of creating a copy for each shard we can simply use the const reference as the updates vector doesn't change and it is safe to access it from other cores. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 8e4f51f)
mmaslankaprv
approved these changes
Aug 21, 2024
|
/ci-repeat 1 |
|
https://redpandadata.atlassian.net/browse/CORE-2632 known CI test failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22977