Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] CORE-6860 SR: Wire up support for compatibility checks #23028

Merged
merged 8 commits into from
Aug 23, 2024
Merged

[v23.3.x] CORE-6860 SR: Wire up support for compatibility checks #23028

merged 8 commits into from
Aug 23, 2024

Conversation

pgellert
Copy link
Contributor

@pgellert pgellert commented Aug 23, 2024 •
edited
Loading

oleiman and others added 8 commits August 23, 2024 09:14
@oleiman @pgellert
sr/types: Introduce verbose flag and compatibility_result
128e13b 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 3771501)
@oleiman @pgellert
sr: Introduce compatility module
ca917b1 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit b27954c)
@oleiman @pgellert
sr/sharded_store: Wire up compatibility_result
5109e5b 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 25fcd5e)
@oleiman @pgellert
sr/swagger: Add messages and verbose flag to compatibility API spec
a6eeaa5 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit d8bcac6)
@oleiman @pgellert
sr/handlers: Wire up compatibility_result
a55d657 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 992a8e7)
@oleiman @pgellert
rpk: check_compatibility --verbose-compat
c7d8588 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 2825e14)
@oleiman @pgellert
dt/sr_test: Test for post_compat messages
f6f2ee4 
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 1e31632)
@pgellert
sr: search backwards for transitive compat checks
c8cfa1d 
This matches the reference implementation and provides a more useful
output because the users likely prefer comparing the new schema against
the most recent incompatible schema.

(cherry picked from commit dcf281c)
@pgellert pgellert added this to the v23.3.x-next milestone Aug 23, 2024
@pgellert pgellert added the kind/backport PRs targeting a stable branch label Aug 23, 2024
@pgellert
Copy link
Contributor Author

Conflicts:

  • No bazel build in v23.3.x
  • No json support in v23.3.x
  • Conflict on header order in sharded_store.cc
  • Conflict on some unbackported lines before the first line of f6f2ee4 (no effect on this commit)
  • Change: vassert.h include path in compatibility.h needed the base/ prefix removed

@pgellert pgellert requested review from a team, andijcr and BenPope and removed request for a team August 23, 2024 08:32
@pgellert pgellert marked this pull request as ready for review August 23, 2024 08:32
@pgellert pgellert self-assigned this Aug 23, 2024
BenPope
BenPope approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgellert pgellert merged commit ed5e31a into redpanda-data:v23.3.x Aug 23, 2024
26 checks passed
@BenPope BenPope modified the milestones: v23.3.x-next, v23.3.21 Sep 3, 2024
@BenPope BenPope mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

@andijcr andijcr andijcr approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@r-vasquez r-vasquez Awaiting requested review from r-vasquez r-vasquez is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

Assignees

@pgellert pgellert

Labels
area/redpanda area/rpk kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.21
Development

Successfully merging this pull request may close these issues.
4 participants
@pgellert @andijcr @BenPope @oleiman