[v24.2.x] CORE-6860 Schema Registry: add detailed verbose compatibility checks #23110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
reviewed
Aug 29, 2024
Comment on lines
483
to
484
| // There must be a compatible reader message for every writer | ||
| // message |
There was a problem hiding this comment.
this doesn't appear in the upstream diff. no clue why 😕
There was a problem hiding this comment.
I must have formatted the file while resolving the merge conflict which shifted the last word to a new line. I've fixed this now to match the original PR.
oleiman
approved these changes
Aug 29, 2024
(cherry picked from commit 4c87c5e)
When an incompatible schema is posted, include the verbose compatibility messages in the error message. This helps users understand the reason for the incompatibility and it matches the reference implementation. Includes a minor fix to the way the compatibility level message is formatted. (cherry picked from commit cda768b)
pgellert
force-pushed
the
vbotbuildovich/backport-22958-v24.2.x-625
branch
from
0a97039 to
51ff964
Compare
|
Force-push: fix comment formatting |
oleiman
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22958
Fixes #23107
Fixes https://redpandadata.atlassian.net/browse/CORE-7073
Conflicts:
proto_compatibility_result check_compatible(std::filesystem::path)in 4520d58. The commits should be identical to the one being cherry-picked.