Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High level topic mount/unmount APIs #23167

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Sep 2, 2024

Added handlers that provide a wrapper around raw data migration APIs.
The operations support mounting and unmounting multiple topics at a
time. The handler creates a corresponding data migration objects and
returns underlying migration id.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Features

  • New REST API for mounting/unmounting topics

@mmaslankaprv
Copy link
Member Author

/dt

@mmaslankaprv mmaslankaprv marked this pull request as ready for review September 3, 2024 07:17
@mmaslankaprv mmaslankaprv requested a review from a team as a code owner September 3, 2024 07:17
src/v/redpanda/admin/data_migration_utils.cc Outdated Show resolved Hide resolved
src/v/redpanda/admin/topics.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@bashtanov bashtanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, one more nit

src/v/redpanda/admin/data_migration_utils.cc Show resolved Hide resolved
Moved the data migration related utility functions to separate file to
make them reusable for topic load/unload handlers.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
Added definitions for topic mount/unmount REST APIs. The definitions are
placed in `migrations.json` file which is counter intuitive but it
allows reusing the data migration related definitions.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
Added handlers that provide a wrapper around raw data migration APIs.
The operations support mounting and unmounting multiple topics at a
time. The handler creates a corresponding data migration objects and
returns underlying migration id.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@mmaslankaprv mmaslankaprv merged commit 9e82969 into redpanda-data:dev Sep 3, 2024
17 checks passed
@mmaslankaprv mmaslankaprv deleted the mount-topic-api branch September 3, 2024 13:21
@bashtanov
Copy link
Contributor

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23167-v24.2.x-460 remotes/upstream/v24.2.x
git cherry-pick -x b346d8d480b5f8b095d2f29ec770bb1da90de8e0 8d4b002c238b16cf45de71a6713c215f2416d319 6d2bb36d82cfb212872e67a70f2b2fbd3350dbe6

Workflow run logs.

@bashtanov bashtanov mentioned this pull request Sep 5, 2024
7 tasks
lf-rep added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants