[v24.2.x] [CORE-7037] schema registry json schema: fixes for some compatiblity bugs #23172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
future proof if some future json schema dialect appears (cherry picked from commit 339d4fd)
only a name change. lambda is_array -> is_tuple, is_tuple is the opposite of is_array. less confusing in the context of is_array_superset (cherry picked from commit 348f004)
the function was wrong, if the property has a "default" field the correct formulation is: is superset if newer["required"] has all the elements of older["required"] or more or every x element in older["reuired"] NOT in newer["required"], has a default value in older["properties"][x] chenged the whole function to just check older["required"] for this property (cherry picked from commit f81507b)
in the case of tuples with different size of elements, excess elements needs to be compatible with the other schema "additionalItems". previously, this property was cheked only for excess elements in newer (cherry picked from commit b6201a1)
the legacy software does not directly check patternProperties. this seems likely an oversight, but for now this check is removed (cherry picked from commit d67bbcc)
andijcr
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23101