Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-7229] storage: add tombstone deletion implementation to local storage compaction #23231

Merged
merged 13 commits into from
Sep 18, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/v/storage/disk_log_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -886,15 +886,10 @@ ss::future<compaction_result> disk_log_impl::do_compact_adjacent_segments(
auto segments = std::vector<ss::lw_shared_ptr<segment>>(
range.first, range.second);

bool all_window_compacted = true;
for (const auto& seg : segments) {
if (!seg->finished_windowed_compaction()) {
all_window_compacted = false;
break;
}
}
const bool all_window_compacted = std::ranges::all_of(
segments, &segment::finished_windowed_compaction);

auto all_segments_self_compacted = std::ranges::all_of(
const bool all_segments_self_compacted = std::ranges::all_of(
Comment on lines -889 to +911
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes like this are great, but don't feel like they need to sit indefinitely in a PR. you can pluck them out and get them merged separately much faster and keep the PR leaner.

segments, &segment::finished_self_compaction);

if (unlikely(!all_segments_self_compacted)) {
Expand Down