Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka: Fixed oversized alloc in describe_log_dirs #23279

Merged
merged 1 commit into from
Sep 12, 2024
Merged

kafka: Fixed oversized alloc in describe_log_dirs #23279

merged 1 commit into from
Sep 12, 2024

Conversation

michael-redpanda
Copy link
Contributor

Replaced:

  • std::vector -> chunked_vector
  • absl::flat_hash_map -> chunked_hash_map

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Bug Fixes

  • Fixed possible oversized alloc in the DescribeLogsDir API handler

@michael-redpanda
kafka: Fixed oversized alloc in describe_log_dirs
7ce5647 
Replaced:
* std::vector -> chunked_vector
* absl::flat_hash_map -> chunked_hash_map

Signed-off-by: Michael Boquard <michael@redpanda.com>
@michael-redpanda michael-redpanda requested a review from a team September 11, 2024 17:18
@michael-redpanda michael-redpanda self-assigned this Sep 11, 2024
@michael-redpanda michael-redpanda requested review from BenPope and StephanDollberg and removed request for a team September 11, 2024 17:18
oleiman
oleiman approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54333#0191e256-6290-470e-8b08-8af919c17f45

@dotnwat dotnwat merged commit a9307e5 into redpanda-data:dev Sep 12, 2024
18 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

This was referenced Sep 12, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

@dotnwat dotnwat dotnwat approved these changes

@BenPope BenPope Awaiting requested review from BenPope BenPope was automatically assigned from redpanda-data/core-enterprise

@StephanDollberg StephanDollberg Awaiting requested review from StephanDollberg

Assignees

@michael-redpanda michael-redpanda

Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michael-redpanda @vbotbuildovich @dotnwat @oleiman