[v24.1.x] kafka: Fixed segfault issue with auditing and mTLS #23290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The audit log system requires that at the Redpanda cluster is configured to use SASL/SCRAM authentication. This is due to permissions applied to the audit log topic (only permitting the audit log system to produce to the audit log topic). When the internal k/client attempts to connect the the node and it reports "illegal_sasl_state", the audit system flags that the audit system is misconfigured. This prevents audit messages from being enqueued into the audit system and in turn ensures that the unaudited action is not performed (that's important). Originally, if the next error message seen is not "illegal_sasl_state" then the flag is unset. However, after reconnect the client may see "broker_not_available" and then "illegal_sasl_state". This commit changes the behavior to wait for neither "illegal_sasl_state" nor "broker_not_available" to be seen before unsetting the flag. Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 51de7bb)
The connection_context::start method enqueues the connect_context instance into the list of connections. If connection_context::stop is called before the item is inserted, then a segfault will happen. Fixes: CORE-7245 Signed-off-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit a5f56c3)
michael-redpanda
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23245