bazel: build RPK with gazelle #23321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockwotj
requested review from
twmb,
r-vasquez,
gene-redpanda and
Deflaimun
as code owners
rockwotj
force-pushed
the
rpk-gazelle
branch
from
92d9297
to
8f1be9a
Compare
via `bazel run //:gazelle`
rockwotj
force-pushed
the
rpk-gazelle
branch
from
8f1be9a
to
6e02b35
Compare
rockwotj
commented
Sep 17, 2024
| embed = [":config"], | ||
| data = ["//conf:redpanda.yaml"], | ||
| env = { | ||
| # NOTE: this is a bit of a hack and rules_go should do this by default |
There was a problem hiding this comment.
Filed an issue here: bazel-contrib/rules_go#4108
rockwotj
force-pushed
the
rpk-gazelle
branch
from
43cc245
to
6bd50fc
Compare
They rely on external state that we need to propagate from Bazel.
rockwotj
force-pushed
the
rpk-gazelle
branch
from
6bd50fc
to
be5cb5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset introduces a set of autogenerated BUILD files that allow us to build rpk with Bazel.
A golang user's guide to bazel:
bazel run //:gazelle, this needs to happen if you modify imports of a package, create a new package or delete an old packagebazel mod tidyand it will automatically add third party (direct!) deps to MODULE.bazel, as they must be listed explicitly.If you have any other questions or concerns about bazel, the team is always available in #p-bazel
Backports Required
Release Notes