[v24.1.x] rpk connect as a managed plugin #23352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag is not used at the moment but it was missing the shorthand parsing. (cherry picked from commit 3c75192)
This commit fixes a bug where if we were parsing a boolean long flag (let's say: --version), we will end up keeping the next argument after the flag, even if it was not needed. (cherry picked from commit e2dff07)
We supported JSON and XML, now we add YAML. (cherry picked from commit 1a49b90)
This change means that from now on, connect will be managed by rpk, so, if a user tries to run `rpk connect <...>` for the first time, rpk will download, install and execute the plugin (connect). It also introduces 3 new commands to `rpk conenct` that live in rpk: install, uninstall, and upgrade. (cherry picked from commit b3e9211)
Increased the timeout to 60, we still have room to grow here since rpk's timeout is 240. (cherry picked from commit 2cc1daf)
(cherry picked from commit 9407659)
Users who manage Redpanda Connect through the redpanda-connect package, or install it manually may not want rpk to rename their binary. (cherry picked from commit 310160c)
Expand the usage and renames Year -> Major (cherry picked from commit 2b3588e)
Now it will prompt the user if the upgrade contains a major version bump. We will also print the installed version in `rpk connect install` for better UX. (cherry picked from commit b251619)
|
Merge must be coordinated with https://github.com/redpanda-data/vtools/pull/3120 |
gene-redpanda
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual backport of all the PRs that makes the feature
rpk connectas a managed plugin:rpk connectas a managed plugin #23117 - Main PR.Backports Required
Release Notes
Improvements
rpk connectnow will be downloaded on the first run.