-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v24.2.x] [CORE-7152] Admin: Introduce endpoint #23368
Merged
oleiman
merged 7 commits into
redpanda-data:v24.2.x
from
oleiman:vbotbuildovich/backport-23314-v24.2.x-830
Sep 19, 2024
Merged
[v24.2.x] [CORE-7152] Admin: Introduce endpoint #23368
oleiman
merged 7 commits into
redpanda-data:v24.2.x
from
oleiman:vbotbuildovich/backport-23314-v24.2.x-830
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- features::license_required_feature Enumeration of redpanda features that require an enterprise license. - features::enterprise_feature_report A thin wrapper around a couple of sets to account for the status of enterprise features (usually based on cluster configs). Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit bf972c0)
Also refactor feature_manager::license_required_feature_enabled to use the report rather than calculating feature status on its own. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 067df42) Conflicts: src/v/cluster/BUILD (diff against not-yet-existing code) src/v/cluster/feature_manager.h (adjacent include)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 653d5a9)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit d6e33cd) Conflicts: src/v/redpanda/admin/BUILD (diff against not-yet-existing script)
Useful for testing enterprise features, since a condition for "RBAC enabled" is the presence of one or more non-default roles. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 5fdc178)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit b5c06fa)
Includes scenarios both with and without a valid license loaded up. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit ebfdd7f)
oleiman
requested review from
a team and
michael-redpanda
and removed request for
a team
September 18, 2024 16:43
michael-redpanda
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to wait for #23370 to get skip_fips
flag
/ci-repeat 1 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #23314