-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v24.2.x] rpk: brokers list exposing Host/Port/Rack/UUID #23686
[v24.2.x] rpk: brokers list exposing Host/Port/Rack/UUID #23686
Conversation
Expose each broker's host, port, rack, and UUID in the 'rpk redpanda admin brokers list' command. Also add a new flag '--include-decommissioned' to list decommissioned brokers with their UUIDs. (cherry picked from commit 08e30aa)
the below tests from https://buildkite.com/redpanda/redpanda/builds/56051#01926e77-3812-40fc-b817-f86d709a3539 have failed and will be retried
|
@@ -37,7 +37,7 @@ require ( | |||
github.com/pkg/errors v0.9.1 | |||
github.com/prometheus/client_model v0.6.1 | |||
github.com/prometheus/common v0.59.1 | |||
github.com/redpanda-data/common-go/rpadmin v0.1.6 | |||
github.com/redpanda-data/common-go/rpadmin v0.1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v24.2.x still uses v0.1.6
, https://github.com/redpanda-data/redpanda/blob/v24.2.x/src/go/rpk/go.mod#L40, but it should be v0.1.7
to use the new GetBrokerUuids
endpoint. Wonder why build didn't fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be fine as your PR also bumped the rpadmin version to v0.1.7
Backport of PR #23595