r/consensus: use term from snapshot when it is available at startup #23835

mmaslankaprv · 2024-10-18T08:09:11Z

If snapshot is available when raft::consensus starts the term from snapshot should initialize Raft protocol term. This fixes a bug in which a term might have move backward after recovery.

Backports Required

Release Notes

Bug Fixes

fixes the term of recovered topic moving backward

If snapshot is available when `raft::consensus` starts the term from snapshot should initialize Raft protocol term. This fixes a bug in which a term might have move backward after recovery. Signed-off-by: Michał Maślanka <michal@redpanda.com>

Signed-off-by: Michał Maślanka <michal@redpanda.com>

src/v/raft/tests/snapshot_recovery_test.cc

Signed-off-by: Michał Maślanka <michal@redpanda.com>

nvartolomei

🔥

vbotbuildovich · 2024-10-18T13:55:50Z

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56811#01929f9e-284d-43bc-b9c9-0cb70df09b14:

"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executed.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.prepared.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.out.stage=.executing.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=None.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executing.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.preparing.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.out.stage=.preparing.use_alias=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56811#01929f9e-2851-4b76-a150-301fa259ec46:

"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executed.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.prepared.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=None.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.out.stage=.executed.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executing.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.preparing.use_alias=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56811#01929f9e-284e-4cfd-8168-969384b85370:

"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executing.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.preparing.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executed.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.prepared.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.out.stage=.executed.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=None.use_alias=False"

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/56811#01929f9e-2850-471a-93d5-d4426e9810a0:

"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executing.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.out.stage=.preparing.use_alias=False"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=False.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.preparing.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.prepared.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=CancellationStage.dir=.in.stage=.executed.use_alias=True"
"rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=TmtpdiParams.cancellation=None.use_alias=True"

vbotbuildovich · 2024-10-18T13:56:06Z

Retry command for Build#56811

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","executed"],true],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","prepared"],true],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["out","executing"],false],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[null,true],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","executing"],true],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","preparing"],true],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["out","preparing"],false],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","executed"],false],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","prepared"],false],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[null,false],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["out","executed"],false],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","executing"],false],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["out","prepared"],false],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","preparing"],false],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","executing"],false],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","preparing"],false],"transfer_leadership":false}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","executed"],false],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["in","prepared"],false],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[["out","executed"],false],"transfer_leadership":true}
tests/rptest/tests/data_migrations_api_test.py::DataMigrationsApiTest.test_migrated_topic_data_integrity@{"params":[null,false],"transfer_leadership":true}

vbotbuildovich · 2024-10-18T13:59:23Z

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56811#01929f9e-2851-4b76-a150-301fa259ec46
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56811#01929f9e-2850-471a-93d5-d4426e9810a0
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56821#0192a059-3e40-4dc9-9ac7-b85ca42dbea5

mmaslankaprv · 2024-10-18T14:46:51Z

/ci-repeat 1

vbotbuildovich · 2024-10-18T21:26:02Z

/backport v24.2.x

vbotbuildovich · 2024-10-18T21:26:03Z

/backport v24.1.x

vbotbuildovich · 2024-10-18T21:26:04Z

/backport v23.3.x

vbotbuildovich · 2024-10-18T21:27:11Z

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23835-v24.1.x-70 remotes/upstream/v24.1.x
git cherry-pick -x 65068aa37b bf10ec4c5c ceea064eeb

Workflow run logs.

vbotbuildovich · 2024-10-18T21:27:15Z

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23835-v23.3.x-997 remotes/upstream/v23.3.x
git cherry-pick -x 65068aa37b bf10ec4c5c ceea064eeb

Workflow run logs.

vbotbuildovich · 2024-10-18T21:27:16Z

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23835-v24.2.x-136 remotes/upstream/v24.2.x
git cherry-pick -x 65068aa37b bf10ec4c5c ceea064eeb

Workflow run logs.

github-actions bot added the area/redpanda label Oct 18, 2024

raft/tests: added work_directory method to raft_node_instance

bf10ec4

Signed-off-by: Michał Maślanka <michal@redpanda.com>

github-actions bot added the area/build label Oct 18, 2024

bashtanov previously approved these changes Oct 18, 2024

View reviewed changes

nvartolomei reviewed Oct 18, 2024

View reviewed changes

src/v/raft/tests/snapshot_recovery_test.cc Outdated Show resolved Hide resolved

r/tests: added test validating state after recovering from snapshot

ceea064

Signed-off-by: Michał Maślanka <michal@redpanda.com>

mmaslankaprv dismissed bashtanov’s stale review via ceea064 October 18, 2024 11:56

mmaslankaprv force-pushed the raft-term-from-snapshot branch from 1570b02 to ceea064 Compare October 18, 2024 11:56

nvartolomei approved these changes Oct 18, 2024

View reviewed changes

bashtanov merged commit 9ffbed5 into redpanda-data:dev Oct 18, 2024
20 checks passed

vbotbuildovich mentioned this pull request Oct 18, 2024

[v24.1.x] r/consensus: use term from snapshot when it is available at startup #23844

Open

This was referenced Oct 18, 2024

[v23.3.x] r/consensus: use term from snapshot when it is available at startup #23845

Open

[v24.2.x] r/consensus: use term from snapshot when it is available at startup #23846

Closed

nvartolomei mentioned this pull request Oct 21, 2024

record all records and validate leader epoch monotonicity redpanda-data/kgo-verifier#58

Merged

mmaslankaprv mentioned this pull request Oct 22, 2024

[v24.2.x] r/consensus: use term from snapshot when it is available at startup #23879

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/consensus: use term from snapshot when it is available at startup #23835

r/consensus: use term from snapshot when it is available at startup #23835

mmaslankaprv commented Oct 18, 2024 •

edited

Loading

nvartolomei left a comment

vbotbuildovich commented Oct 18, 2024 •

edited

Loading

vbotbuildovich commented Oct 18, 2024 •

edited

Loading

vbotbuildovich commented Oct 18, 2024 •

edited

Loading

mmaslankaprv commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

r/consensus: use term from snapshot when it is available at startup #23835

r/consensus: use term from snapshot when it is available at startup #23835

Conversation

mmaslankaprv commented Oct 18, 2024 • edited Loading

Backports Required

Release Notes

Bug Fixes

nvartolomei left a comment

Choose a reason for hiding this comment

vbotbuildovich commented Oct 18, 2024 • edited Loading

vbotbuildovich commented Oct 18, 2024 • edited Loading

Retry command for Build#56811

vbotbuildovich commented Oct 18, 2024 • edited Loading

mmaslankaprv commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

vbotbuildovich commented Oct 18, 2024

mmaslankaprv commented Oct 18, 2024 •

edited

Loading

vbotbuildovich commented Oct 18, 2024 •

edited

Loading

vbotbuildovich commented Oct 18, 2024 •

edited

Loading

vbotbuildovich commented Oct 18, 2024 •

edited

Loading