Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] Fix ghost node handling in raft heartbeats #23934

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Oct 28, 2024

Backport of PR #23916
Fixes #23930

ztlpn added 3 commits October 28, 2024 20:51
…ns_test

The cluster can't become healthy until ghost nodes are decommissioned.

(cherry picked from commit 12bb4ec)
…g node

Previously, we replied with "failure", which updated the last heartbeat
timestamp and gave the leader an impression that the group is actually there.
Reply with group_unavailable, which is more appropriate here.

(cherry picked from commit 25541ce)
Usually this is a new node replying to heartbeats addressed to the
corresponding ghost node.

(cherry picked from commit 1c23c35)
@ztlpn ztlpn added this to the v24.1.x-next milestone Oct 28, 2024
@ztlpn ztlpn added the kind/backport PRs targeting a stable branch label Oct 28, 2024
@vbotbuildovich
Copy link
Collaborator

the below tests from https://buildkite.com/redpanda/redpanda/builds/57238#0192d4b1-28bb-4494-b465-a0085f48428d have failed and will be retried

partition_balancer_planner_test_rpunit
gtest_archival_rpunit

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Oct 28, 2024

@mmaslankaprv mmaslankaprv merged commit 3b0603c into redpanda-data:v24.1.x Oct 29, 2024
19 checks passed
@BenPope BenPope modified the milestones: v24.1.x-next, v24.1.18 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants