Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVEX-36] rpk: change expiry check for free_trial #23951

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Oct 29, 2024

If it's a free trial license the expiry warning
check threshold will be set to 15 days instead of
30 for the rest of the license types.

Fixes DEVEX-36 and DEVEX-37

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • None

If it's a free trial license the expiry warning
check threshold will be set to 15days instead of
30 for the rest of license types.

Fixes DEVEX-36
twmb
twmb previously approved these changes Oct 29, 2024
Now the license nags will be shown for customers
with free_trial licenses that has less than 15
days left.
@r-vasquez
Copy link
Contributor Author

Added 84a3ff0 to solve DEVEX-37

Now we will show the license nag for customers with free_trial licenses that has less than 15 days left.

For example:

rpk cluster health                           

WARNING: your TRIAL license is about to expire. The following Enterprise features are being used in your Redpanda cluster: [partition_auto_balancing_continuous]. These features require a license. To get a license, contact us at https://www.redpanda.com/contact. For more information, see https://docs.redpanda.com/current/get-started/licenses/#redpanda-enterprise-edition

CLUSTER HEALTH OVERVIEW
=======================
Healthy:                          true
Unhealthy reasons:                []
...

@r-vasquez
Copy link
Contributor Author

c14a9b9 added a new automatic text wrap for the message depending on the terminal size to improve readability.

image
image

Better readability since it's a long line.
@r-vasquez r-vasquez merged commit 8211880 into redpanda-data:dev Oct 30, 2024
22 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23951-v24.1.x-514 remotes/upstream/v24.1.x
git cherry-pick -x 76dec5a2b7 84a3ff0fc2 663291e4c7

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-23951-v24.2.x-445 remotes/upstream/v24.2.x
git cherry-pick -x 76dec5a2b7 84a3ff0fc2 663291e4c7

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants