Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform-sdk/go/tests: remove -quiet flag #23978

Merged
merged 1 commit into from
Oct 31, 2024
Merged

transform-sdk/go/tests: remove -quiet flag #23978

merged 1 commit into from
Oct 31, 2024

Conversation

rockwotj
Copy link
Contributor

This was only added for custom logging we put in tinygo, but we will remove that now that we're using upstream tinygo and not a fork.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

  • none

This was only added for custom logging we put in tinygo, but we will remove that now that we're using upstream tinygo and not a fork.
@rockwotj rockwotj requested a review from r-vasquez October 31, 2024 17:49
@github-actions github-actions bot added the area/wasm WASM Data Transforms label Oct 31, 2024
@rockwotj rockwotj requested a review from oleiman October 31, 2024 17:50
@rockwotj rockwotj self-assigned this Oct 31, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're using upstream tinygo and not a fork

nice

@rockwotj
Copy link
Contributor Author

Yeah it's not worth the effort to keep rebuilding and maintaining the fork. We'll just use upstream binaries.

@rockwotj rockwotj enabled auto-merge October 31, 2024 17:59
@rockwotj rockwotj merged commit 64375e9 into dev Oct 31, 2024
20 of 21 checks passed
@rockwotj rockwotj deleted the tinygo branch October 31, 2024 18:09
@rockwotj
Copy link
Contributor Author

rockwotj commented Nov 6, 2024

/backport v24.2.0

@rockwotj
Copy link
Contributor Author

rockwotj commented Nov 6, 2024

/backport v24.1.0

@rockwotj
Copy link
Contributor Author

rockwotj commented Nov 6, 2024

/backport v23.3.0

@vbotbuildovich
Copy link
Collaborator

Oops! Something went wrong.

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wasm WASM Data Transforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants