[CORE-6992] cloud_storage_clients/abs_client: use item filter in list_objects #24439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like an oversight. Noticed in an ABS run of a test:
```
INFO 2024-11-12 02:16:37,966 [shard 1:main] cloud_storage - topic_manifest_downloader.cc:102 - Labeled topic manifest download resulted in 2 matching manifests with prefix '', printing first 2
INFO 2024-11-12 02:16:37,966 [shard 1:main] cloud_storage - topic_manifest_downloader.cc:112 - Match for hint '': meta/kafka/topic-a/83123841-40c1-47e4-92ed-5ac8d1f536c7/8/topic_manifest.bin
INFO 2024-11-12 02:16:37,966 [shard 1:main] cloud_storage - topic_manifest_downloader.cc:112 - Match for hint '': meta/kafka/topic-a/eb0359d1-a0fb-45aa-8995-d938a34caeef/8_lifecycle.bin
WARN 2024-11-12 02:16:37,966 [shard 1:main] kafka - create_topics.cc:185 - Failed to create topic(s) {{kafka/topic-a}} error_code observed: cluster::errc::topic_operation_error
```
In this snippet, the list results contain a lifecycle marker, despite
the filter passed in during manifest download being
ends_with("topic_manifest.bin").
Auditing the codebase a bit, there don't appear to be any other usages
of list_objects() with a filter.
Testing with ABS would have caught a bug in the ABS client during topic recovery when there are multiple objects within a topic's manifest path prefix (e.g. from different clusters).
|
/backport v24.3.x |
|
/backport v24.2.x |
This was referenced Dec 5, 2024
Merged
|
@andrwng does the updated test catch the bug now? |
Yea it fails without this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like an oversight. Noticed in an ABS run of a test:
In this snippet, the list results contain a lifecycle marker, despite
the filter passed in during manifest download being
ends_with("topic_manifest.bin").
Auditing the codebase a bit, there don't appear to be any other usages
of list_objects() with a filter.
Backports Required
Release Notes
Bug Fixes