-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-1620] Use log_reader
in the ntp_archiver
#24690
Open
Lazin
wants to merge
3
commits into
redpanda-data:dev
Choose a base branch
from
Lazin:pr/use-log-reader-in-the-ntp-archiver
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CORE-1620] Use log_reader
in the ntp_archiver
#24690
Lazin
wants to merge
3
commits into
redpanda-data:dev
from
Lazin:pr/use-log-reader-in-the-ntp-archiver
+562
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
The ntp_archiver doesn't store the smart pointer so there is no point to pass smart pointer into the async_data_uploader if async_data_uploader is invoked by the ntp_archiver. Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
Only normal upload is implemented. The code uses async_data_uploader to read data from storage layer using reader instead of reading files from disk directly. The new implementation is a drop in replacement but it's not swapped yet. Signed-off-by: Evgeny Lazin <4lazin@gmail.com>
Retry command for Build#60291please wait until all jobs are finished before running the slash command
|
dotnwat
changed the title
Use
[CORE-1620] Use Jan 8, 2025
log_reader
in the ntp_archiver
log_reader
in the ntp_archiver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
ntp_archiver
implementation is reading data from segments directly. This makes it tied to storage implementation which makes it difficult to evolve the storage.This PR introduces new upload mechanism based on
storage::log_reader
interface andoffset_range_size
method of the log. Instead of uploading segment files new implementation uploads offset ranges based on heuristics (it tries to produce segments of certain size frequently enough).Currently, only normal uploads are handled this way. Compacted reupload and adjacent segment merging are not touched.
This is still work in progress. Unit tests that expect uploads to happen on a segment boundary will fail.
Backports Required
Release Notes