ducktape: Increase partition density to 2k per shard in the MPT #24710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase partition density to 2k partitions per shard and adapt the test to use the new memory group aware config.
kgo-repeaters start to get pretty loaded at higher partition densities so the status query can take a bit longer.
StephanDollberg
force-pushed
the
stephan/mpt-new-limits
branch
from
478891d to
417bb75
Compare
|
Partial fix for https://redpandadata.atlassian.net/browse/CORE-8732. |
travisdowns
reviewed
Jan 7, 2025
| @@ -43,12 +43,16 @@ | |||
| BIG_FETCH = 104857600 | |||
|
|
|||
| # How much memory to assign to redpanda per partition. Redpanda will be started | |||
| # with MIB_PER_PARTITION * PARTITIONS_PER_SHARD * CORE_COUNT memory | |||
| DEFAULT_MIB_PER_PARTITION = 4 | |||
| # with (MIB_PER_PARTITION * PARTITIONS_PER_SHARD * CORE_COUNT) / (PARTITIONS_MEMORY_ALLOCATION_PERCENT / 100) memory | |||
There was a problem hiding this comment.
Should be / (PARTITIONS_MEMORY_ALLOCATION_PERCENT be * / (PARTITIONS_MEMORY_ALLOCATION_PERCENT)?
There was a problem hiding this comment.
* / (PARTITIONS_MEMORY_ALLOCATION_PERCENT)
Do you mean * 100 / PARTITIONS_MEMORY_ALLOCATION_PERCENT?
travisdowns
reviewed
Jan 7, 2025
|
|
||
| # How many partitions we will create per shard: this is the primary scaling | ||
| # factor that controls how many partitions a given cluster will get. | ||
| DEFAULT_PARTITIONS_PER_SHARD = 1000 | ||
| DEFAULT_PARTITIONS_PER_SHARD = 2000 |
There was a problem hiding this comment.
Almost feels like we should read it from config, but anyway LGTM.
travisdowns
reviewed
Jan 7, 2025
StephanDollberg
commented
Jan 8, 2025
| partition_replicas_per_node + per_node_slack) | ||
| memory_setting = mib_per_partition * ( | ||
| partition_replicas_per_node + | ||
| per_node_slack) * (self.partition_memory_reserve_percentage / 100.) |
There was a problem hiding this comment.
Miscommitted some last minute changes I was playing around with. Needs to be /
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the partition density in the MPT to 2k per shard and use the new memory group aware config.
As discussed the plan is to raise this to 3k but that makes us currently run into an oversized alloc (large enough to fail the test) so that needs to be fixed first before we can increase the density in the test further (see https://redpandadata.slack.com/archives/C04B5T58QQ1/p1736265968267079).
Backports Required
Release Notes