[v24.1.x] CORE-8721 security: check std::uncaught_exceptions() in ~request_auth_result()
#24740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now check `std::uncaught_exceptions()` in the destructor to avoid throwing exceptions during stack unwinding. This ensures that if an exception is already in flight, no additional exceptions will be thrown, which would otherwise lead to a call to `std::terminate()`. (cherry picked from commit aaa539e)
pgellert
approved these changes
Jan 9, 2025
Retry command for Build#60485please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#60485
|
|
/ci-repeat 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24727