Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.3.x] [CORE-8485] Reset translation state on snapshot #24747

Merged
merged 3 commits into from
Jan 9, 2025
Merged

[v24.3.x] [CORE-8485] Reset translation state on snapshot #24747

merged 3 commits into from
Jan 9, 2025

Conversation

mmaslankaprv
Copy link
Member

Backport of PR #24522

@mmaslankaprv
raft/tests: added option to enable offset trannslation in tests
53965f4 
Signed-off-by: Michał Maślanka <michal@redpanda.com>
(cherry picked from commit f34856c)
@mmaslankaprv
datalake/tests: enable offset translation in state machine test
05aacd5 
Signed-off-by: Michał Maślanka <michal@redpanda.com>
(cherry picked from commit f454ef2)
@mmaslankaprv
translation_stm: reset highest translated offset on raft snapshot
7a08c37 
When an stm receives Raft snapshot it indicates the whole in memory
state of that state machine should be replaced with the state from the
snapshot. The datalake translation state machine was incorrectly
handling raft snapshot which lead to its state being out of date after
the snapshot is applied. Raft snapshot for translation_stm is empty so
the correct action is to reset the state machine state and wait for the
update to be applied.

Fixes: CORE-8485

Signed-off-by: Michał Maślanka <michal@redpanda.com>
(cherry picked from commit 8985f57)
@mmaslankaprv mmaslankaprv added this to the v24.3.x-next milestone Jan 9, 2025
@mmaslankaprv mmaslankaprv added the kind/backport PRs targeting a stable branch label Jan 9, 2025
@mmaslankaprv mmaslankaprv requested review from bharathv and ztlpn January 9, 2025 17:36
@mmaslankaprv mmaslankaprv marked this pull request as ready for review January 9, 2025 17:36
@mmaslankaprv mmaslankaprv requested a review from bashtanov January 9, 2025 18:00
@mmaslankaprv mmaslankaprv enabled auto-merge January 9, 2025 18:00
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#60521
test_id test_kind job_url test_status passed
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.S3.retention_type=retention.bytes ducktape https://buildkite.com/redpanda/redpanda/builds/60521#01944c68-0b21-4a89-bbe8-3b01e5fe5c19 FLAKY 5/6
rptest.tests.maintenance_test.MaintenanceTest.test_maintenance_sticky.use_rpk=False ducktape https://buildkite.com/redpanda/redpanda/builds/60521#01944c83-c85f-42fb-967f-cf31ae08dce8 FLAKY 5/6

@mmaslankaprv mmaslankaprv merged commit a24131b into redpanda-data:v24.3.x Jan 9, 2025
17 checks passed
@BenPope BenPope modified the milestones: v24.3.x-next, v24.3.4 Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathv bharathv bharathv approved these changes

@ztlpn ztlpn Awaiting requested review from ztlpn

@bashtanov bashtanov Awaiting requested review from bashtanov

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mmaslankaprv @vbotbuildovich @bharathv @BenPope