-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE-8754] Handle new TLS error codes #24749
Merged
michael-redpanda
merged 2 commits into
redpanda-data:dev
from
michael-redpanda:new-tls-err-codes/core-8754
Jan 9, 2025
Merged
[CORE-8754] Handle new TLS error codes #24749
michael-redpanda
merged 2 commits into
redpanda-data:dev
from
michael-redpanda:new-tls-err-codes/core-8754
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seastar now reports new error codes for certain TLS connection issues: * `ERROR_WRONG_VERSION_NUMBER` * `ERROR_HTTP_REQUEST` * `ERROR_HTTPS_PROXY_REQUEST` Signed-off-by: Michael Boquard <michael@redpanda.com>
When a non TLS connection attempts to connect and send data to a Redpanda TLS enabled endpoint, OpenSSL may report different error codes depending on what it sees on the incoming packet: * `ERROR_WRONG_VERSION_NUMBER` - reported when OpenSSL inspects the packet expecting to see a known TLS version but the one it sees is unknown. This is distinct to seeing an unsupported version. * `ERROR_HTTP_REQUEST` - similar to `ERROR_WRONG_VERSION_NUMBER`, however in this situation, the packet starts with a known HTTP verb (e.g. `GET`, or `POST`, etc). * `ERROR_HTTPS_PROXY_REQUEST` - like `ERROR_HTTP_REQUEST`, however the packet starts with `CONNE` Signed-off-by: Michael Boquard <michael@redpanda.com>
dotnwat
approved these changes
Jan 9, 2025
CI test resultstest results on build#60527
|
/backport v24.3.x |
/backport v24.2.x |
Failed to create a backport PR to v24.3.x branch. I tried:
|
Failed to create a backport PR to v24.2.x branch. I tried:
|
This was referenced Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement changes in Redpanda to handle new TLS error codes added by redpanda-data/seastar#166.
These error codes provide more specificity about why connections failed to establish TLS connections.
When a non TLS connection attempts to connect and send data to a Redpanda
TLS enabled endpoint, OpenSSL may report different error codes depending on
what it sees on the incoming packet:
ERROR_WRONG_VERSION_NUMBER
- reported when OpenSSL inspects the packet expecting to see a known TLS version but the one it sees is unknown. This is distinct to seeing an unsupported version.ERROR_HTTP_REQUEST
- similar toERROR_WRONG_VERSION_NUMBER
, however in this situation, the packet starts with a known HTTP verb (e.g.GET
, orPOST
, etc).ERROR_HTTPS_PROXY_REQUEST
- likeERROR_HTTP_REQUEST
, however the packet starts withCONNE
Backports Required
Release Notes
Improvements