Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.3.x] bazel: add rp_util and compat #24786

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #24732

(cherry picked from commit f40aadd)
(cherry picked from commit 9123ece)
Fixes: CORE-7462
(cherry picked from commit 8a6895d)
At some point we switched to using a body_writer for this instead of
string, but that broke rputil, fix it by writing all the body to an
iobuf then printing it to stdout.

Fixes: CORE-8753
(cherry picked from commit f2afd7c)
The organization here of the headers was a mess, because the headers
only needed to work out at the end when included in `run.cc`. However,
bazel runs clang-tidy on header only libraries, so we actually need
each header to compile standalone.

(cherry picked from commit 7cc7d00)
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Jan 13, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 13, 2025
@rockwotj rockwotj enabled auto-merge January 13, 2025 14:05
@rockwotj
Copy link
Contributor

backprting the schema printing fixes. The bazel stuff is unused on 234.3.x

@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#60648
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60648#01945ffc-5715-481e-a943-0f9b4396b9fa FLAKY 1/2

@rockwotj rockwotj merged commit be694fb into redpanda-data:v24.3.x Jan 13, 2025
17 checks passed
@BenPope BenPope modified the milestones: v24.3.x-next, v24.3.4 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants