Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.3.x] c/topic_table: notify ntp delta waiters in batches #24790

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[v24.3.x] c/topic_table: notify ntp delta waiters in batches #24790

merged 1 commit into from
Jan 15, 2025

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #24761

@ztlpn @vbotbuildovich
c/topic_table: notify ntp delta waiters in batches
02db2cb 
When installing a controller snapshot or creating a topic with many
partitions, the number of pending deltas can grow quite large. Notify
waiters in batches to avoid stalls. This should also fix the problem
with controller_backend notification handler that will spawn a lot of
ready tasks if the task quota is exceeded.

(cherry picked from commit 6263550)
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Jan 13, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 13, 2025
@vbotbuildovich vbotbuildovich requested a review from ztlpn January 13, 2025 19:04
@vbotbuildovich
Copy link
Collaborator Author

vbotbuildovich commented Jan 13, 2025 •
edited
Loading

CI test results

test results on build#60663
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60663#0194610e-ebdb-4011-bd57-0d673dc05d67 FAIL 0/2
rptest.tests.idempotency_test.IdempotencyWriteCachingTest.test_idempotent_producers_write_caching ducktape https://buildkite.com/redpanda/redpanda/builds/60663#01946152-ae7b-42a8-8ad9-8412a52ebc5a FLAKY 4/6
rptest.tests.partition_force_reconfiguration_test.NodeWiseRecoveryTest.test_node_wise_recovery.dead_node_count=2 ducktape https://buildkite.com/redpanda/redpanda/builds/60663#0194616e-30ef-441f-9235-598d724871b8 FLAKY 5/6
test results on build#60741
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/60741#019466e7-a2bd-4777-a2a5-10a7226fd712 FLAKY 1/2
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.ABS.retention_type=retention.bytes ducktape https://buildkite.com/redpanda/redpanda/builds/60741#01946732-c733-46d1-990e-c0b7b03171d0 FLAKY 3/6

@ztlpn
Copy link
Contributor

ztlpn commented Jan 14, 2025

@ztlpn ztlpn enabled auto-merge January 14, 2025 22:20
@ztlpn ztlpn merged commit 1d76c1a into redpanda-data:v24.3.x Jan 15, 2025
17 checks passed
@BenPope BenPope modified the milestones: v24.3.x-next, v24.3.4 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztlpn ztlpn ztlpn approved these changes

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@vbotbuildovich @ztlpn @BenPope