Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.3.x] CORE-8804 Make brokers field no longer required #24903

Conversation

vbotbuildovich
Copy link
Collaborator

@vbotbuildovich vbotbuildovich commented Jan 23, 2025

Backport of PR #24891

Fixes: CORE-8890

This permits users to specify a single client property without having to
also specify the brokers the client can connect to.  This is helpful
when using docker and passing something like `--set
pandaproxy_client.produce_compression_type=lz4` to `rpk redpanda start`.

NOTE: Kafka endpoint discovery will NOT occur if you specify a client
config.  Once you specify one entry, you must specify the brokers entry
if the Kafka API is not `127.0.0.1:9092`.

Signed-off-by: Michael Boquard <michael@redpanda.com>
(cherry picked from commit d3fe0f2)
@vbotbuildovich vbotbuildovich requested a review from a team as a code owner January 23, 2025 13:30
@vbotbuildovich vbotbuildovich added this to the v24.3.x-next milestone Jan 23, 2025
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 23, 2025
@michael-redpanda michael-redpanda self-assigned this Jan 23, 2025
Copy link
Contributor

@michael-redpanda michael-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport

@vbotbuildovich
Copy link
Collaborator Author

CI test results

test results on build#61101
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61101#0194935c-b9c6-47e6-b72e-47b0e8d6c100 FLAKY 1/2
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.S3.retention_type=retention.bytes ducktape https://buildkite.com/redpanda/redpanda/builds/61101#019493b8-541f-4cee-86ff-88cd081f9818 FLAKY 1/2

@michael-redpanda michael-redpanda merged commit 493a29f into redpanda-data:v24.3.x Jan 23, 2025
18 checks passed
@BenPope BenPope modified the milestones: v24.3.x-next, v24.3.4 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants