Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE-8999] [v24.2.x] Schema Registry/protobuf: Allow older protobuf and add a test for map field. #24974

Merged
merged 2 commits into from
Jan 29, 2025
Merged

[CORE-8999] [v24.2.x] Schema Registry/protobuf: Allow older protobuf and add a test for map field. #24974

merged 2 commits into from
Jan 29, 2025

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Jan 29, 2025 •
edited
Loading

  • Drop support for editions
  • Add a test for a map field

The test is expected to fail until https://github.com/redpanda-data/vtools/pull/3429 is merged.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

Bug Fixes

  • Schema Registry: Fix a regression with protobuf map fields

@BenPope BenPope requested a review from IoannisRP January 29, 2025 14:06
@BenPope
Schema Registry/protobuf: Remove support for editions.
26371ee 
This allows a downgrade of protobuf to v24.4

Protobuf v25 adds a check that breaks compatibility.
@BenPope
schema_registry/protobuf: Add test for map field
5b7766a 
Signed-off-by: Ben Pope <ben@redpanda.com>
@BenPope BenPope self-assigned this Jan 29, 2025
@BenPope BenPope added the area/schema-registry Schema Registry service within Redpanda label Jan 29, 2025
@BenPope BenPope added this to the v24.2.17 milestone Jan 29, 2025
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Jan 29, 2025 •
edited
Loading

Retry command for Build#61354

please wait until all jobs are finished before running the slash command



/ci-repeat 1
tests/rptest/tests/schema_registry_test.py::SchemaRegistryAutoAuthTest.test_serde_client@{"client_type":2,"protocol":2,"skip_known_types":false}
tests/rptest/tests/schema_registry_test.py::SchemaRegistryTest.test_serde_client@{"client_type":2,"protocol":2,"skip_known_types":false}
tests/rptest/tests/schema_registry_test.py::SchemaRegistryAutoAuthTest.test_serde_client@{"client_type":2,"protocol":2,"skip_known_types":true}
tests/rptest/tests/schema_registry_test.py::SchemaRegistryTest.test_serde_client@{"client_type":2,"protocol":2,"skip_known_types":true}

@BenPope
Copy link
Member Author

BenPope commented Jan 29, 2025 •
edited
Loading

All failures are expected: .test_serde_client@{"client_type":2,"protocol":2,

@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#61354
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61354#0194b267-6298-4f62-8008-743ada5a2358 FLAKY 1/2
rptest.tests.schema_registry_test.SchemaRegistryAutoAuthTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=False ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2a8-fcb1-4c92-92ef-39f41a5a581a FAIL 0/1
rptest.tests.schema_registry_test.SchemaRegistryAutoAuthTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=False ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2aa-835a-499b-bf0a-2cca36234c9a FAIL 0/1
rptest.tests.schema_registry_test.SchemaRegistryAutoAuthTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=True ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2a8-fcaf-4d50-9177-37f36055c1fc FAIL 0/6
rptest.tests.schema_registry_test.SchemaRegistryAutoAuthTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=True ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2aa-835b-4196-9715-0553a3824ea7 FAIL 0/6
rptest.tests.schema_registry_test.SchemaRegistryTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=False ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2a8-fcb1-4c92-92ef-39f41a5a581a FAIL 0/1
rptest.tests.schema_registry_test.SchemaRegistryTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=False ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2aa-835a-499b-bf0a-2cca36234c9a FAIL 0/1
rptest.tests.schema_registry_test.SchemaRegistryTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=True ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2a8-fcaf-4d50-9177-37f36055c1fc FAIL 0/1
rptest.tests.schema_registry_test.SchemaRegistryTest.test_serde_client.protocol=PROTOBUF.client_type=Java.skip_known_types=True ducktape https://buildkite.com/redpanda/redpanda/builds/61354#0194b2aa-835b-4196-9715-0553a3824ea7 FAIL 0/1

@michael-redpanda michael-redpanda merged commit 78569c9 into redpanda-data:v24.2.x Jan 29, 2025
13 of 17 checks passed
@BenPope BenPope changed the title [v24.2.x] Schema Registry/protobuf: Allow older protobuf and add a test for map field. [CORE-8999] [v24.2.x] Schema Registry/protobuf: Allow older protobuf and add a test for map field. Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IoannisRP IoannisRP IoannisRP approved these changes

Assignees

@BenPope BenPope

Labels
area/redpanda area/schema-registry Schema Registry service within Redpanda
Projects
None yet
Milestone
v24.2.17
Development

Successfully merging this pull request may close these issues.
4 participants
@BenPope @vbotbuildovich @IoannisRP @michael-redpanda