Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] schema_registry/protobuf: Add test for legacy_map #25010

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[v24.2.x] schema_registry/protobuf: Add test for legacy_map #25010

merged 1 commit into from
Feb 3, 2025

Conversation

BenPope
Copy link
Member

@BenPope BenPope commented Feb 3, 2025

Backport of PR #25001

Fixes: #25008
Fixes: CORE-8999

@BenPope
schema_registry/protobuf: Add test for legacy_map
0c2da74 
The Confluent Schema Registry client renders maps in the
expanded form demonstrated by the test, which is considered
invalid by libprotobuf >= v25.

The patch required to fix this is:
redpanda-data/vtools#3434

Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit d33def4)
@BenPope BenPope added area/schema-registry Schema Registry service within Redpanda kind/backport PRs targeting a stable branch labels Feb 3, 2025
@BenPope BenPope added this to the v24.2.x-next milestone Feb 3, 2025
@BenPope BenPope requested a review from IoannisRP February 3, 2025 16:30
@BenPope BenPope self-assigned this Feb 3, 2025
@BenPope BenPope enabled auto-merge February 3, 2025 16:40
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#61519
test_id test_kind job_url test_status passed
gtest_raft_rpunit.gtest_raft_rpunit unit https://buildkite.com/redpanda/redpanda/builds/61519#0194cca9-cc8b-4fa9-80e4-019a9116689b FLAKY 1/2

@BenPope BenPope merged commit 52dd63b into redpanda-data:v24.2.x Feb 3, 2025
19 checks passed
@piyushredpanda piyushredpanda modified the milestones: v24.2.x-next, v24.2.18 Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IoannisRP IoannisRP IoannisRP approved these changes

Assignees

@BenPope BenPope

Labels
area/redpanda area/schema-registry Schema Registry service within Redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v24.2.18
Development

Successfully merging this pull request may close these issues.
4 participants
@BenPope @vbotbuildovich @IoannisRP @piyushredpanda