Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Move api docs from /etc/redpanda to /usr/share/redpanda #311

Merged
merged 1 commit into from
Dec 21, 2020
Merged

config: Move api docs from /etc/redpanda to /usr/share/redpanda #311

merged 1 commit into from
Dec 21, 2020

Conversation

rkruze
Copy link
Contributor

@rkruze rkruze commented Dec 19, 2020

Addressess #310

Checklist

When referencing a related issue, remember to migrate duplicate stories from the
external tracker. This is not relevant for most users.

BenPope
BenPope approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@BenPope BenPope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emaxerrno
emaxerrno approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@emaxerrno emaxerrno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending we push a fix to vtools for correct packaging.

@0xdiba - we should do the same for the dashboard.

@rkruze
Copy link
Contributor Author

rkruze commented Dec 19, 2020

Here is the PR for vtools. https://github.com/vectorizedio/vtools/pull/68

@0xdiba
Copy link
Contributor

0xdiba commented Dec 21, 2020

Actually saw after accepting, but I think we could change these https://github.com/vectorizedio/redpanda/blob/dev/src/go/rpk/pkg/config/config_test.go#L503 (4 occurences). Not needed for the change but it's good to be consistent.

Also, this and the vtools PR should get merged synchronously.

@BenPope
Copy link
Member

BenPope commented Dec 21, 2020

And https://github.com/vectorizedio/deployment-automation needs changing (ansible, as well as helm).

@rkruze
Copy link
Contributor Author

rkruze commented Dec 21, 2020

I took care of the changes needed in rpk tests. I'll prepare a PR for helm and ansible.

@rkruze rkruze merged commit c2c8599 into redpanda-data:dev Dec 21, 2020
@rkruze
Copy link
Contributor Author

rkruze commented Dec 22, 2020

@BenPope You mentioned changes needed in Ansible? I might be missing something, but I don't see a reference to them today. Thanks!

@BenPope
Copy link
Member

BenPope commented Dec 22, 2020

@BenPope You mentioned changes needed in Ansible? I might be missing something, but I don't see a reference to them today. Thanks!

I misremembered.

Musikmang65
Musikmang65 reviewed Jan 5, 2021
View reviewed changes
Copy link

@Musikmang65 Musikmang65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wire not connecting

@BenPope
Copy link
Member

BenPope commented Jan 5, 2021

Hi @Musikmang65, can you describe your issue a little more?

@emaxerrno
Copy link
Contributor

@BenPope seems like a spam account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Musikmang65 Musikmang65 Musikmang65 left review comments

@0xdiba 0xdiba 0xdiba approved these changes

@BenPope BenPope BenPope approved these changes

@emaxerrno emaxerrno emaxerrno approved these changes

@0x5d 0x5d Awaiting requested review from 0x5d

@dotnwat dotnwat Awaiting requested review from dotnwat

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rkruze @0xdiba @BenPope @emaxerrno @Musikmang65