Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubebuilder project #6202

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Fix kubebuilder project #6202

merged 3 commits into from
Aug 25, 2022

Conversation

pvsune
Copy link
Contributor

@pvsune pvsune commented Aug 24, 2022

Cover letter

Fixes kubebuilder project:

  • Running go test ./... for envtests hangs during cleanup REF
  • Update PROJECT config to be compatible with latest kubebuilder v3.6.0 and fixes scaffolding of API/Webhook
  • CRLFMTs code to avoid diff when running make test

Backport Required

  • not a bug fix
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

UX changes

None

Release notes

None

Longer timeout for waiting kube-apiserver to stop
Kubebuilder commands fail because missing boilerplate text
Update PROJECT config to be compatible with kubebuilder 3.6.0
@pvsune pvsune requested a review from a team as a code owner August 24, 2022 05:44
Formats code with CRLFMT to avoid diff when running make test
Copy link
Contributor

@joejulian joejulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pvsune pvsune merged commit f4cc424 into redpanda-data:dev Aug 25, 2022
@pvsune pvsune deleted the fix/kubebuilder branch August 25, 2022 00:15
@@ -0,0 +1,8 @@
// Copyright 2021 Redpanda Data, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants