Fix ControllerEraseTest.test_erase_controller_log
#8400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
reviewed
Jan 25, 2023
jcsp
previously approved these changes
Jan 25, 2023
jcsp
approved these changes
Jan 26, 2023
|
Failure #8179 |
|
/backport v22.3.x |
|
Failed to run cherry-pick command. I executed the below command: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr added new admin_api request, which returns last_applied_offset and commited_index for controller log. And test now delete all segment with start_offset >
last_applied_offsetProblem in test was:
Test delete last segment from disk and after startup node should signal that last_applied_offset does not present on the disk.
But in this test run node only replicated last controller log segment, but not applied it. So last_applied_offset was from another segment on the disk, which test did not delete.
Fixes #8217
Backports Required
UX Changes
Release Notes
/v1/debug/controller_status