Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-1125 Add note about replication slot prefix #200

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

asimms41
Copy link
Contributor

@asimms41 asimms41 commented Mar 19, 2025

Description

Resolves DOC-1125
Review deadline: 21 March

The change is related to a breaking change in the naming convention for PostgreSQL logical replication slots in Redpanda Connect.

Documentation update:

  • Added a note indicating that starting from version 4.48.1, replication slot names are no longer created with the prefix rs_. Users who want to continue using a replication slot created by an earlier version should manually add the rs_ prefix to the slot name.

Page previews

postgres_cdc input

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Copy link

hyperlint-ai bot commented Mar 19, 2025

PR Change Summary

Updated documentation to reflect changes in replication slot naming conventions for PostgreSQL logical replication.

  • Added a note about the removal of the rs_ prefix for replication slot names starting from version 4.48.1.
  • Clarified that a random name is generated if no name is provided for the replication slot.

Modified Files

  • modules/components/pages/inputs/postgres_cdc.adoc

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for redpanda-connect ready!

Name Link
🔨 Latest commit 0a14016
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-connect/deploys/67e539f7c159b500088869c8
😎 Deploy Preview https://deploy-preview-200--redpanda-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asimms41 asimms41 marked this pull request as ready for review March 20, 2025 10:41
@asimms41 asimms41 requested a review from a team as a code owner March 20, 2025 10:41
@asimms41 asimms41 requested review from rockwotj and mihaitodor March 20, 2025 10:41
@asimms41 asimms41 requested a review from rockwotj March 24, 2025 10:52
@asimms41 asimms41 merged commit 6b6281b into main Mar 27, 2025
7 checks passed
@asimms41 asimms41 deleted the DOC-1125_replication_slot_prefix branch March 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants