Seastar changes for abort on OOM #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a global "abort on OOM" setting in the seastar, and we allow enabling it via a public method in seastar::memory. There was no corresponding method to disable it, but such a method is useful in order to give applications full control over this setting. Introduce a new method which takes a boolean parameter in order to allow both enabling and disabling the abort behavior. The old call is deprecated and simply falls the new method with enabled=true.
Add an is_abort_on_allocation_failure method which returns the global state of this reactor option. This is useful for applications that which to query this state in order to expose it for debugging or administration purposes. Applications could try to track this themselves, but this is unreliable since the reactor itself can change this value based on the command line flags.
A basic test which flips the abort on OOM switch up and down and which checks that the is_enabled function returns the correct value.
Replace enable_abort_on_allocation_failure with set_abort_on_allocation_failure(true) as the former is deprecated.
To include details of the set_abort_on_allocation_failure API.
travisdowns
force-pushed
the
td-abort-on-oom
branch
from
2dfa8f2 to
10271e9
Compare
|
The upstream change is taking a while, but it seems like this is the version that will be accepted by upstream, so I think we can review & merge this even before upstream. See here for the upstream review: |
dotnwat
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving to enable abort-on-OOM by default, and as part of this it is useful to be able to disable as well as enable this setting (current behavior is that it starts out disabled and the reactor does a one-time enable based on the command line flag --abort-on-seastar-bad-alloc.
This series implements the ability to disable it and also to get its status.
A small test is included.
There is a parallel PR for this same series on the scylladb side here:
scylladb#1506
So we should give that a bit of time to see if there are changes there and realign in order to avoid merging issues later.