Validate Tiers Against API #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-redpanda
force-pushed
the
add-tiers-call
branch
from
0523013 to
a5eab94
Compare
Adds support, mocks and testing for calling the API to get the valid tiers as part of the throughput_tier validation process
gene-redpanda
force-pushed
the
add-tiers-call
branch
from
a5eab94 to
b37cd1d
Compare
Our previous solution wasn't workable. The issue is that configure is called after schema so we aren't able to create a client that can be passed through to the validator. And unfortunately the Schema function is called with an empty struct for request so we can't access it there either (the original gameplan). An alternative path was passing connections/clients into the resource through the provider's Resources function but this is called before the provider's Configure so it also can't access the relevant client/connection. This commit resolves the issue by eliminating the validator and handling tier validation prior to the cluster create call. This should slightly speed things along but isn't the meaningful advantage over having the API invalidate us that the prior validator method (which runs at the plan stage and is massively faster but unfortunately working off static info) brought. There is a possible solution but it comes from the API: don't require ID/Secret to access the throughput tier endpoint. This seems out of scope at this time.
r-vasquez
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for validating throughput tiers against the API endpoint added for that purpose and removes the static throughput tier validator. See commit message here for more info on why we couldn't do this through the validator.