Skip to content

Conversation

@RobotLeopard86
Copy link

@RobotLeopard86 RobotLeopard86 commented Oct 28, 2025

Warning

The hardware IO layer (for Spark MAX) has not yet been tuned or tested

Currently Implemented Features

  • Output subsystem interface
  • IO layer with AdvantageKit auto-logged inputs
  • Implementation of the IO layer for Spark MAX
  • Implementation of the IO layer for simulation
  • Output firing command with configurable velocity and time parameters
  • Configurable PID and feedforward constants

Hope this all looks good!

Added public-facing interface, IO layer interface, and skeleton of Spark Max IO implementation
@RobotLeopard86 RobotLeopard86 changed the title Merge initial implementation of output subsystem Output/launcher subsystem Oct 28, 2025
@RobotLeopard86 RobotLeopard86 marked this pull request as draft October 28, 2025 23:23
@RobotLeopard86 RobotLeopard86 marked this pull request as ready for review November 5, 2025 00:57
@RobotLeopard86 RobotLeopard86 self-assigned this Nov 6, 2025
@RobotLeopard86
Copy link
Author

Hey Aceius (or whoever), I made a unit conversion mistake while converting the sim logic from SparkMaxSim to DCMotorSim, so the PID tuning was wrong. Please don't merge this until I fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants