Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove doc tag from content type value #2

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Remove doc tag from content type value #2

merged 3 commits into from
Jan 25, 2022

Conversation

csucu
Copy link

@csucu csucu commented Jan 24, 2022

Added fix for doctags in content types, taken from: redsift/go.enmime@3644cf8

@csucu csucu requested a review from dmotylev January 24, 2022 11:38
@csucu csucu changed the title Changes for bad content-types Remove doc tag from content type value Jan 24, 2022
dmotylev
dmotylev reviewed Jan 24, 2022
View reviewed changes
mediatype/mediatype.go Outdated Show resolved Hide resolved
@csucu csucu changed the base branch from master to development January 25, 2022 14:17
dmotylev
dmotylev approved these changes Jan 25, 2022
View reviewed changes
Copy link

@dmotylev dmotylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; although for upstream PRs it might need a better description. You will have to check their rules for that

@csucu csucu merged commit c236668 into development Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmotylev dmotylev dmotylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csucu @dmotylev