Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add high cardinality tags and routing #10

Merged
merged 4 commits into from
Jul 31, 2024
Merged

add high cardinality tags and routing #10

merged 4 commits into from
Jul 31, 2024

Conversation

jpicht
Copy link
Contributor

@jpicht jpicht commented Jul 31, 2024

High cardinality metrics

We currently do not want to push high cardinality metrics to datadog. In staging we are testing a supplementary system that can handle high cardinality.

This PR introduces

  • a new interface HighCardinalityCollector that separates tags into low and high cardinality tags
  • an adapter class to use two Collector instances as a HighCardinalityCollector (one for high cardinality metrics, one for low cardinality metrics)

@jpicht jpicht requested a review from earada July 31, 2024 10:26
@jpicht jpicht requested a review from dmotylev as a code owner July 31, 2024 10:26
earada
earada previously approved these changes Jul 31, 2024
@jpicht jpicht force-pushed the high-cardinality branch from 4c32497 to 09c7d03 Compare July 31, 2024 10:51
@jpicht jpicht merged commit 4046dcb into master Jul 31, 2024
3 checks passed
@jpicht jpicht deleted the high-cardinality branch July 31, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants