Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to semaphoreslim waits #58

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Conversation

Cheesebaron
Copy link
Collaborator

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

I have a production app where the App ends up in a deadlock because somehow the calling SemaphoreSlim.Wait inside of AndHUD ends up in a deadlock.

🆕 What is the new behavior (if this is a feature change)?

I haven't been able to narrow down what exactly causes this, but it mainly happens when trying to dismiss AndHUD that is showing on Activity A, while navigating to Activity B.

💥 Does this PR introduce a breaking change?

Worst case AndHUD won't dismiss if there is a timeout waiting for the semaphore.

🐛 Recommendations for testing

Try the bottom most "Deadlock" item in the Sample App

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated
  • Rebased onto current develop

@Cheesebaron Cheesebaron changed the title Bugfix/semaphoreslim timeouts Add timeouts to semaphoreslim waits Apr 24, 2024
@Cheesebaron Cheesebaron merged commit 2749fcf into main Apr 24, 2024
1 check passed
@Cheesebaron Cheesebaron deleted the bugfix/semaphoreslim-timeouts branch April 24, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant