Add timeouts to semaphoreslim waits #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
I have a production app where the App ends up in a deadlock because somehow the calling
SemaphoreSlim.Wait
inside of AndHUD ends up in a deadlock.🆕 What is the new behavior (if this is a feature change)?
I haven't been able to narrow down what exactly causes this, but it mainly happens when trying to dismiss AndHUD that is showing on Activity A, while navigating to Activity B.
💥 Does this PR introduce a breaking change?
Worst case AndHUD won't dismiss if there is a timeout waiting for the semaphore.
🐛 Recommendations for testing
Try the bottom most "Deadlock" item in the Sample App
📝 Links to relevant issues/docs
🤔 Checklist before submitting