New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade peerDependency for redux to ^3.7.2 #167

Merged

bdwain merged 1 commit into redux-loop:master from mDibyo:dibyo/upgrade-peer-dependency-redux

Nov 20, 2017

Contributor

mDibyo commented Nov 15, 2017

redux-loop/index.d.ts relies on the AnyAction type introduced in redux@3.7.2 (reduxjs/redux#2467 (comment)).

AFAIK, the redux-loop implementation itself doesn't depend on features introduced in 3.7.2.

If we want to keep the peerDependency at redux@^3.0.0, an alternate solution would be removing the AnyAction import and defining it ourselves. This doesn't seem like that big a deal: https://github.com/reactjs/redux/blob/master/index.d.ts#L25


          Upgrade peerDependency for redux to ^3.7.2

f3052b1

Member

bdwain commented Nov 20, 2017

makes sense. 3.7.2 has been out a while. i don't see much benefit in using an earlier version of 3.

thanks!

bdwain merged commit f59e154 into redux-loop:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet