-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshooting docs: epics fail silently when returning subscribe from epic #331
Comments
This is unfortunately another example of #263 and ReactiveX/rxjs#2813. There is an error about not providing an Observable where it was expected, it's just being swallowed silently due to a bug. As ReactiveX/rxjs#2813 mentions though, while this is a bug, in the future this behavior will likely be intentional, though almost certainly with a better debugging experience by still showing the error in the debug console (which is what most people actually care about when they freak out about this change lol). |
This adds to the clarification of read-only epics, by linking to an issue that goes into more depth on the scenario. closes redux-observable#331
…rors (#332) * docs(troubleshooting): Side effects with subscribe closes #331 * docs(troubleshooting): Clarifying read-only epics This clarifies that the suggested pattern is meant for 'read-only' scenarios and that you should always return an Observable. * docs(troubleshooting): Linking to issue for read-only epics This adds to the clarification of read-only epics, by linking to an issue that goes into more depth on the scenario. closes #331
When you return a subscribe from an epic, it just fails silently and none of the epics execute. I'm going to submit a PR with an example on how to do side effects without using
subscribe
.The text was updated successfully, but these errors were encountered: