Skip to content

chore(webpack): update webpack, and fix babel-loader preset to be env #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2019
Merged

chore(webpack): update webpack, and fix babel-loader preset to be env #612

merged 1 commit into from
Feb 15, 2019

Conversation

jayphelps
Copy link
Member

@jayphelps jayphelps commented Feb 15, 2019 •
edited
Loading

This should get our tests back to green.

--

For those interested in digging, our tests were broken because of a change in webpack-cli, just had to upgrade: webpack/webpack-cli#607

@jayphelps jayphelps requested a review from evertbouw February 15, 2019 05:21
@evertbouw evertbouw merged commit a3c09bc into master Feb 15, 2019
@MaximeBernard MaximeBernard deleted the webpack-upgrade branch May 3, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertbouw evertbouw evertbouw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayphelps @evertbouw