Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sideEffects: false to enable tree shaking #295

Merged
merged 1 commit into from
May 7, 2018
Merged

Add sideEffects: false to enable tree shaking #295

merged 1 commit into from
May 7, 2018

Conversation

anajavi
Copy link
Contributor

@anajavi anajavi commented May 7, 2018

This PR enables webpack 4 to do tree shaking on es-build.

It adds sideEffects: false to package.json, which tells webpack that imports don't have sideEffects. https://webpack.js.org/guides/tree-shaking/

@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          14       14           
  Lines         110      110           
  Branches       36       36           
=======================================
  Hits          105      105           
  Misses          4        4           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652668c...266642c. Read the comment docs.

@timche
Copy link
Member

timche commented May 7, 2018

Cool, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants